build: export Core as Uppy #3981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something is messed up with tests and import/export or config 🤔 @aduh95 do you see what could be the issue? |
|
Maybe it’s fixed with updated |
aduh95
reviewed
Aug 16, 2022
Comment on lines
36
to
40
| static COMPANION = 'https://api2.transloadit.com/companion' | ||
|
|
||
| // Regex matching acceptable postMessage() origins for authentication feedback from companion. | ||
| static ALLOWED_COMPANION_PATTERN = /\.transloadit\.com$/ | ||
|
|
There was a problem hiding this comment.
I though we would not do that, and instead define them as static only in the bundle?
Murderlon
reviewed
Aug 16, 2022
Comment on lines
28
to
30
| const COMPANION = 'https://api2.transloadit.com/companion' | ||
| // Regex matching acceptable postMessage() origins for authentication feedback from companion. | ||
| const ALLOWED_COMPANION_PATTERN = /\.transloadit\.com$/ |
There was a problem hiding this comment.
Since this is a breaking change already, good opportunity to use more intention revealing names. COMPANION sounds like it contains the instance.
Suggested change
| const COMPANION = 'https://api2.transloadit.com/companion' | |
| // Regex matching acceptable postMessage() origins for authentication feedback from companion. | |
| const ALLOWED_COMPANION_PATTERN = /\.transloadit\.com$/ | |
| const COMPANION_URL = 'https://api2.transloadit.com/companion' | |
| // Regex matching acceptable postMessage() origins for authentication feedback from companion. | |
| const COMPANION_URL_PATTERN = /\.transloadit\.com$/ |
There was a problem hiding this comment.
It's not a breaking change now, we decided to just add exports to the CDN bundle.
aduh95
reviewed
Aug 16, 2022
packages/uppy/index.mjs
Outdated
Comment on lines
53
to
54
| export { COMPANION as TRANSLOADIT_COMPANION } from '@uppy/transloadit' | ||
| export { ALLOWED_COMPANION_PATTERN as TRANSLOADIT_ALLOWED_COMPANION_PATTERN } from '@uppy/transloadit' |
There was a problem hiding this comment.
Suggested change
| export { COMPANION as TRANSLOADIT_COMPANION } from '@uppy/transloadit' | |
| export { ALLOWED_COMPANION_PATTERN as TRANSLOADIT_ALLOWED_COMPANION_PATTERN } from '@uppy/transloadit' | |
| import { default as Transloadit, COMPANION, ALLOWED_COMPANION_PATTERN } from '@uppy/transloadit' | |
| Transloadit.COMPANION = COMPANION | |
| Transloadit.ALLOWED_COMPANION_PATTERN = ALLOWED_COMPANION_PATTERN |
arturi
changed the title
aduh95
approved these changes
Aug 16, 2022
aduh95
pushed a commit
that referenced
this pull request
Aug 16, 2022
aduh95
pushed a commit
that referenced
this pull request
Aug 16, 2022
aduh95
added a commit
to aduh95/uppy
that referenced
this pull request
Aug 18, 2022
`Uppy` call is now exported as `Uppy` instead of `Core`. Refs: transloadit#3981
aduh95
added a commit
to aduh95/uppy
that referenced
this pull request
Aug 18, 2022
`Uppy` call is now exported as `Uppy` instead of `Core`. Refs: transloadit#3981
aduh95
added a commit
that referenced
this pull request
Aug 18, 2022
`Uppy` call is now exported as `Uppy` instead of `Core`. Refs: #3981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.