Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/provider-views: fix race condition when adding folders #4384

Merged
merged 26 commits into from
Apr 4, 2023
Merged

@uppy/provider-views: fix race condition when adding folders #4384

merged 26 commits into from
Apr 4, 2023

Commits on Mar 28, 2023

  1. fix race condtion when adding files 

    don't call addFolder from listAllFiles
because that would call addFile before all folders were loaded

also remove unused selectedFolders state
    @mifi
    mifi committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    9b093ae View commit details
    Browse the repository at this point in the history

  2. fix also the case of adding multiple folders

    @mifi
    mifi committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    25f6228 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. fix todo: remove SharedHandler

    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    cd121f3 View commit details
    Browse the repository at this point in the history

  2. remove loaderWrapper

    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    ea3cb23 View commit details
    Browse the repository at this point in the history

  3. fix logic

    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    c80f11a View commit details
    Browse the repository at this point in the history

  4. fix the last race condition

    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    c533c90 View commit details
    Browse the repository at this point in the history

  5. fix broken duplicate file check

    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    cd5d099 View commit details
    Browse the repository at this point in the history

  6. fix logic

    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    67023a8 View commit details
    Browse the repository at this point in the history

  7. prettiyfy loop

    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    80bd293 View commit details
    Browse the repository at this point in the history

  8. add user feedback 

    so they know that something is happening
    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    4060019 View commit details
    Browse the repository at this point in the history

  9. run corepack yarn run build:locale-pack

    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    85548ce View commit details
    Browse the repository at this point in the history

  10. Revert "run corepack yarn run build:locale-pack" 

    This reverts commit 85548ce.
    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    647e48e View commit details
    Browse the repository at this point in the history

  11. Revert "add user feedback" 

    This reverts commit 4060019.
    @mifi
    mifi committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    5434fc8 View commit details
    Browse the repository at this point in the history

  12. use async generator instead of p-map

    @aduh95
    aduh95 committed Mar 29, 2023
    3 Configuration menu
    Copy the full SHA
    50a0bec View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. re-fix race-condition

    @mifi
    mifi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    f91b514 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-addfiles-race-condition

    @mifi
    mifi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    6abcb94 View commit details
    Browse the repository at this point in the history

  3. remove providerFileToId 

    as suggested by @arturi
    @mifi
    mifi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    b5d6b78 View commit details
    Browse the repository at this point in the history

  4. use addFiles instead of addFile

    @mifi
    mifi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    fa3e66f View commit details
    Browse the repository at this point in the history

  5. rename function

    @mifi
    mifi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    4795c41 View commit details
    Browse the repository at this point in the history

  6. use provider-supplied file ID 

    instead of generating an ID, for providers that we whitelsit
this allows adding the same time many times (with a different path)
    @mifi
    mifi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    75ab3d5 View commit details
    Browse the repository at this point in the history

  7. call core directly

    @mifi
    mifi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    79abf68 View commit details
    Browse the repository at this point in the history

  8. improve dev dashboard

    @mifi
    mifi committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    cf01707 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. disable experimental getAsFileSystemHandle 

    it seems to be causing problems when dropping folders with subfolders in newest chrome
e.g a folder with 50 files and a subfolder which in turn has another 50 files

also refactor and document the code more
    @mifi
    mifi committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    d1d9132 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. Update packages/@uppy/provider-views/src/ProviderView/ProviderView.jsx 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @mifi @aduh95
    mifi and aduh95 authored Apr 1, 2023
    Configuration menu
    Copy the full SHA
    8f5c32d View commit details
    Browse the repository at this point in the history

  2. mov eto utils

    @mifi
    mifi committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    46368c8 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2023

  1. Merge branch 'main' into fix-addfiles-race-condition

    @aduh95
    aduh95 authored Apr 2, 2023
    Configuration menu
    Copy the full SHA
    cf91ef2 View commit details
    Browse the repository at this point in the history