@uppy/provider-views: show how many files are added #4388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't call addFolder from listAllFiles because that would call addFile before all folders were loaded also remove unused selectedFolders state
so they know that something is happening
This reverts commit 85548ce.
This reverts commit 4060019.
while loading this lets the user know that we are doing something, and that the process has not crashed or gotten stuck see #4384
This was referenced Mar 29, 2023
|
If you add more margin in between the items I'm okay with this 👍 Did you test on mobile? |
aduh95
changed the title
mifi
added a commit
that referenced
this pull request
Apr 4, 2023
|
Ok added new margin and recreated this PR in #4399 so closing this. did not test on mobile, but i tested with a smaller width and i don't see what would be different on mobile? |
mifi
added a commit
that referenced
this pull request
Apr 15, 2023
* show how many files are added when loading remake of #4388 * add french (cherry pick) * add todo
mifi
added a commit
that referenced
this pull request
Apr 15, 2023
* show how many files are added when loading remake of #4388 * add french (cherry pick) * implement concurrent file listing
mifi
added a commit
that referenced
this pull request
Apr 15, 2023
* show how many files are added when loading remake of #4388 * add french (cherry pick) * implement concurrent file listing * refactor / fix lint * refactor/reduce duplication * pull out totals validation don't do it for every file added, as it's very slow instead do the check at the end when all files are added. this allows us to easily work with 10k+ files fixes #4389 * Update packages/@uppy/core/src/Uppy.js Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> * make restricter.validate validate everything instead make more specific methods for sub-validation also rename validateTotals to validateAggregateRestrictions * improve errors and user feedback - handle errors centrally so that we can limit the amount of toasts (informers) sent to the users (prevent flooding hundreds/thousands of them) - introduce FileRestrictionError which is a restriction error for a specific file - introduce isUserFacing field for RestrictionError * fix performance issue reintroduced * improvements - show "%{count} additional restrictions were not fulfilled" for any restriction errors more than 4 - refactor/rename methods - improve ghost logic/comments * improve performance when uploading - introduce new event "upload-start" that can contain multiple files - make a new patchFilesState method to allow updating more files - unify "upload-start" logic in all plugins (send it before files start uploading) - defer slicing buffer until we need the data - refactor to reuse code * fix e2e build issue * try to upgrade cypress maybe it fixes the error * Revert "fix e2e build issue" This reverts commit ff3e580. * upgrade parcel * move mutation logic to end * remove FileRestrictionError merge it with RestrictionError * fix silly bug looks like the e2e tests are doing its job 👏 --------- Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while loading
this lets the user know that we are doing something, and that the process has not crashed or gotten stuck
see discussion in #4384