@uppy/aws-s3-multipart: Read from globalThis in functions
#4584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing `globalThis` before the functions are called causes `require` errors in server rendered environments as soon as the `createSignedURL.js` file is imported because `globalThis.crypto` is `undefined`.
bryanjswift
changed the title
globalThis in functionsglobalThis in functions
|
im seeing this error as well. |
arturi
approved these changes
Jul 18, 2023
aduh95
approved these changes
Jul 19, 2023
Merged
github-actions bot
added a commit
that referenced
this pull request
Jul 20, 2023
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/aws-s3-multipart | 3.5.1 | @uppy/provider-views | 3.4.1 | | @uppy/companion-client | 3.2.2 | @uppy/status-bar | 3.2.3 | | @uppy/dashboard | 3.5.0 | @uppy/utils | 5.4.2 | | @uppy/locales | 3.2.4 | uppy | 3.13.0 | - meta: Add i18n to CONTRIBUTING.md (Mikael Finstad / #4591) - @uppy/provider-views: Add VirtualList to ProviderView (Merlijn Vos / #4566) - @uppy/provider-views: fix race conditions with folder loading (Mikael Finstad / #4578) - @uppy/status-bar: fix ETA when status bar is installed during upload (Antoine du Hamel / #4588) - @uppy/provider-views: fix infinite folder loading (Mikael Finstad / #4590) - meta: examples/aws: client-side signing (Antoine du Hamel / #4463) - meta: Bump word-wrap from 1.2.3 to 1.2.4 (dependabot[bot] / #4586) - meta: e2e: increase `requestTimeout` to 16s (Antoine du Hamel / #4587) - @uppy/locales: update zh_TW translation (5idereal / #4583) - @uppy/aws-s3-multipart: fix crash on pause/resume (Merlijn Vos / #4581) - @uppy/aws-s3-multipart: do not access `globalThis.crypto` on the top-level (Bryan J Swift / #4584)
Murderlon
added a commit
that referenced
this pull request
Jul 25, 2023
* main: @uppy/aws-s3-multipart: refresh file before calling user-defined functions (#4557) Release: uppy@3.13.0 (#4595) Add i18n to CONTRIBUTING.md (#4591) Add VirtualList to ProviderView (#4566) @uppy/provider-views: fix race conditions with folder loading (#4578) @uppy/status-bar: fix ETA when status bar is installed during upload (#4588) @uppy/provider-views: fix infinite folder loading (#4590) examples/aws: client-side signing (#4463) Bump word-wrap from 1.2.3 to 1.2.4 (#4586) e2e: increase `requestTimeout` to 16s (#4587) @uppy/locales: update zh_TW translation (#4583) @uppy/aws-s3-multipart: fix crash on pause/resume (#4581) @uppy/aws-s3-multipart: do not access `globalThis.crypto` on the top-level (#4584) Release: uppy@3.12.0 (#4574) @uppy/transloadit: fix error message (#4572) @uppy/provider-views: add support for remote file paths (#4537) @uppy/transloadit: implement Server-sent event API (#4098)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing
globalThisbefore the functions are called causesrequireerrors in server rendered environments as soon as thecreateSignedURL.jsfile is imported becauseglobalThis.cryptoisundefined.