Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: fix update-contributors script #5137

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 2, 2024

The previous script was making the release script fail, and the use of a npx child process was a non-ideal choice when we can directly call the JS library.

Copy link
Contributor

github-actions bot commented May 2, 2024

Diff output files
No diff

The following build files have been modified and might affect the actual diff:

bin/update-contributors.mjs

@aduh95 aduh95 merged commit 77c6b25 into transloadit:main May 2, 2024
17 checks passed
@aduh95 aduh95 deleted the main branch May 2, 2024 20:10
@github-actions github-actions bot mentioned this pull request May 3, 2024
github-actions bot added a commit that referenced this pull request May 3, 2024
| Package          | Version | Package          | Version |
| ---------------- | ------- | ---------------- | ------- |
| @uppy/companion  |  4.13.2 | @uppy/xhr-upload |   3.6.6 |
| @uppy/core       |  3.11.1 | uppy             |  3.25.1 |
| @uppy/locales    |   3.5.3 |                  |         |

- @uppy/locales: Update ru_RU locale  (Uladzislau Bodryi / #5120)
- meta: fix `update-contributors` script (Antoine du Hamel / #5137)
- meta: fix `bullet` setting for ReMark (Antoine du Hamel)
- meta: add prettier to `.md` pre-commit hooks (Antoine du Hamel)
- @uppy/core: make UppyEventMap more readable (Murderlon)
- meta: enable prettier for markdown (Merlijn Vos / #5133)
- @uppy/xhr-upload: do not throw when res is missing url (Merlijn Vos / #5132)
- @uppy/companion: coerce `requestUrl` to a string (Antoine du Hamel / #5128)
Murderlon added a commit that referenced this pull request May 6, 2024
* 4.x:
  Release: uppy@4.0.0-beta.5 (#5141)
  meta: run Prettier in the release workflow
  Release: uppy@3.25.1 (#5139)
  Bump ejs from 3.1.9 to 3.1.10 (#5135)
  Update ru_RU locale  (#5120)
  meta: fix `update-contributors` script (#5137)
  meta: fix `bullet` setting for ReMark
  meta: add prettier to `.md` pre-commit hooks
  @uppy/core: make UppyEventMap more readable
  Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant