Add PATCH to valid XHR types #5279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
Jun 27, 2024
| @@ -15,7 +15,7 @@ export interface XHRUploadOptions extends PluginOptions { | |||
| timeout?: number | |||
| responseUrlFieldName?: string | |||
| endpoint: string | |||
| method?: 'GET' | 'POST' | 'PUT' | 'HEAD' | 'get' | 'post' | 'put' | 'head' | |||
| method?: 'GET' | 'POST' | 'PUT' | 'HEAD' | 'PATCH' | 'get' | 'post' | 'put' | 'head' | 'patch' | |||
There was a problem hiding this comment.
IMO we should defined all the methods listed in https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods, plus all the lowercase version of the standard ones, minus the ones that would send a SecurityError. As discussed in the previous issue, lowercase patch is not valid, and only supported on 3.x for backward-compatibility.
Suggested change
| method?: 'GET' | 'POST' | 'PUT' | 'HEAD' | 'PATCH' | 'get' | 'post' | 'put' | 'head' | 'patch' | |
| method?: | |
| | 'GET' | |
| | 'HEAD' | |
| | 'POST' | |
| | 'PUT' | |
| | 'DELETE' | |
| | 'OPTIONS' | |
| | 'PATCH' | |
| | 'delete' | |
| | 'get' | |
| | 'head' | |
| | 'options' | |
| | 'post' | |
| | 'put' | |
| | string |
Could you also update the type in the source file please? Currently it is lacking quite a bunch of valid types:
aduh95
pushed a commit
that referenced
this pull request
Jun 27, 2024
|
Landed in 46fd4d7 |
|
Thank you for doing this on my behalf! |
Merged
github-actions bot
added a commit
that referenced
this pull request
Jun 27, 2024
| Package | Version | Package | Version | | ---------------- | ------- | ---------------- | ------- | | @uppy/dashboard | 3.9.1 | uppy | 3.27.1 | | @uppy/xhr-upload | 3.6.8 | | | - @uppy/xhr-upload: add `'PATCH'` as valid method (Quinn Daley / #5279) - @uppy/dashboard: fix handling of `null` for `doneButtonHandler` (Antoine du Hamel / #5283) - meta: Bump docker/build-push-action from 5.4.0 to 6.1.0 (dependabot[bot] / #5272) - docs: rewrite Instagram dev setup section (Evgenia Karunus / #5274) - meta: remove the Zoom section from `CONTRIBUTING.md` (Evgenia Karunus / #5273)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for fixing #5165 a couple of months back! I'm in the process of migrating my codebase to TS and this has hit me again because PATCH isn't in the list of valid methods.
PATCH is commonly used in Rails backends for issuing updates to existing records, so I think this would benefit more than just me. I know it works well because I've been using it for a long time in untyped JS.
Let me know if you need any more info!