Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/aws-s3: clarify and warn when incorrect buckets settings are used #5505

Merged
merged 6 commits into from
Nov 11, 2024
Merged

@uppy/aws-s3: clarify and warn when incorrect buckets settings are used #5505

merged 6 commits into from
Nov 11, 2024

Commits on Nov 8, 2024

  1. fix warning not showing 

    when CORS is not setup properly on the bucket, it would just fail silently.
now it will show the warning again (because location/etag may also be `undefined`)
    @mifi
    mifi committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    b753964 View commit details
    Browse the repository at this point in the history

  2. add comment and improve types

    @mifi
    mifi committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8bd9f5b View commit details
    Browse the repository at this point in the history

  3. add new dev uploader s3-non-multipart 

    that will never use multipart
and `s3` will auto-detect (which is the default anyways)
    @mifi
    mifi committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3682b75 View commit details
    Browse the repository at this point in the history

  4. fix comment

    @mifi
    mifi committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    588bd1f View commit details
    Browse the repository at this point in the history

  5. add POST to docs too 

    needed for s3
    @mifi
    mifi committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3b06078 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Undo local dev changes

    @Murderlon
    Murderlon committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    caaec02 View commit details
    Browse the repository at this point in the history