feat(webdav): initial implementation for a WebDAV simple auth provider

[dschmidt]

As #4621 got stale and @Murderlon suggested to implement only the SimpleAuth part of it... here we go.

I intentionally left out any visual configuration for now, I would like to get the actual functionality merged asap and deal with everything else in a followup.

I couldn't make the translations work (at least not the ones in the AuthForm) in the dev server, any hints for that?
Otherwise it works for me (tm)

[dschmidt]

Seen the type errors ... will fix tomorrow

[dschmidt]

@Murderlon fixed the type issues, but I'm clueless about the compare_diff test... it looks like new dependencies should be installed by

uppy/.github/workflows/e2e.yml

Lines 110 to 114 in 44a378a

	corepack yarn workspaces focus $(\
	corepack yarn workspaces list --json | \
	jq -r .name | \
	awk '/^@uppy-example/{ next } { if ($0!="uppy.io") print $0 }'\
	)

but it doesn't seem to work?

[Murderlon]

Looks good overall! Thanks a lot for picking this up 👌

[Murderlon]

I'm clueless about the compare_diff test

Perhaps reverting your changes for the action and resolving #5528 (comment) will help

[dschmidt]

I'm clueless about the compare_diff test

Perhaps reverting your changes for the action and resolving #5528 (comment) will help

I'm afraid I can't easily change that (as commented above) - do you have any other ideas?
Also I'm still struggling with the translations as written in the PR text - any ideas here?

Apart from that everything seems to work and I've addressed all your comments (I think), thanks for the feedback!

[Murderlon]

I'm afraid I can't easily change that (as commented above) - do you have any other ideas?
Also I'm still struggling with the translations as written in the PR text - any ideas here

I can take a look later

[Murderlon]

I can't make changes because you don't allow edits from contributors.

Try to add this to .github/workflows/e2e.yml (line 127)

        run: |
          git checkout FETCH_HEAD -- packages
+     - run: corepack yarn install
      - run: corepack yarn build:js:typeless

[dschmidt]

I can't make changes because you don't allow edits from contributors.

Maybe that's because I've sent the PR from the owncloud organization... mh :-\

Try to add this to .github/workflows/e2e.yml (line 127)

        run: |
          git checkout FETCH_HEAD -- packages
+     - run: corepack yarn install
      - run: corepack yarn build:js:typeless

Still failing :-\

[Murderlon]

Let's undo f657f79 and I'll merge it. I'm pretty sure it's just problematic for PRs introducing a new dependency, which I can sort out in main and doesn't have to block this PR.

[mifi]

Nice stuff!

1. Should we have an e2e test for this or would that be very hard to implement? maybe there's a simple mock webdav server implemented in node.js or we can apt install a webdav server and start it up in cypress?
2. should we have docs at https://github.com/transloadit/uppy.io ?
3. ui not pretty but I guess we can merge it as-is for now. at least it works

[dschmidt]

I will address @mifi 's comments asap, not sure what to do with the useCallback ... and I still need help with the translations, any hints?

[Murderlon]

I still need help with the translations, any hints?

I'm traveling and away from my laptop till 16 December. @mifi would be great if you can help get this over the finish line.

[mifi]

I don't think you need to translate anything. You've added them English keys, and AFAIK it will fallback to those.

[dschmidt]

But it doesnt work! The keys are not picked up is what I'm saying

[dschmidt]

@mifi ping, any help with the translations?

[dschmidt]

Incorporated your feedback @mifi, now only the translations aren't working yet afaict.

It would be great to have tests but not being familiar with your setup that would be quite some effort again for me and delay all of this further :-(

I guess we also could and should have docs, but I would tackle that in a follow up after having added a few customization options.
For now I would love to get the feature in to avoid merge conflicts and iterate then

[mifi]

@mifi ping, any help with the translations?

similar issue maybe? #5542

[Murderlon]

@mifi ping, any help with the translations?

Sorry for the long wait, I was hoping this would be resolved while I was gone but I'm back now and can take a look.

[mifi]

Sorry i had to prioritize node-sdk v4 last week