Enable smart linking #1252
Merged
Enable smart linking #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterDaveHello
previously approved these changes
Aug 31, 2019
|
@someperson would you like to bind the commit author with your GitHub account? Like change the email of the commit author or add that email in your GitHub account. I can directly merge it if you don't mind, but I don't want to lose anyone's credit in accident ;) |
someperson
force-pushed
the
smart-linking
branch
from
4a5d831
to
bc0871e
Compare
|
@PeterDaveHello Thanks for the heads-up. I just pushed a corrected commit with the right information. |
|
@someperson nice! |
|
I've tested on Ubuntu x64 and everything looks fine, now going to test on Windows and Linux x86, armv6/7, and then we can merge this. |
PeterDaveHello
approved these changes
Sep 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is kind of necessary for the Cocoa build unless certain references to the macOS framework headers are removed from transgui. Otherwise, there is a dependency on Carbon that cannot be resolved in the x86_64 macOS world, causing problems during compilation. See https://wiki.freepascal.org/univint
These flags enable smart linking, which causes anything that isn't used to be dropped at compile-time. Importantly, that includes the Carbon dependency when compiling for Cocoa.
I don't know how to figure out exactly what would need to be removed to get rid of the Carbon dependency, so this was the easier solution. Since it affects the other builds, at the request of @PeterDaveHello, I have separated it into its own pull request. In theory, this shouldn't break anything, but it obviously requires testing.