Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change the font size in lyrics editor #40

Merged

Conversation

shipurjan
Copy link
Contributor

@shipurjan shipurjan commented Feb 3, 2024

Add font change event on Ctrl+wheel, Ctrl+{+,-} and menu with zoom buttons

As requested in issue #38

@tranxuanthang
Copy link
Owner

I've tested your PR and the added feature works really well, thank you for your work! There is one thing above that needs to be addressed, once it's resolved, it'll be ready to merge.

Copy link
Contributor Author

@shipurjan shipurjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I felt something was wrong about that comment, but my IDE didn't complain and I couldn't put my finger on it

@tranxuanthang tranxuanthang merged commit 8b9bd41 into tranxuanthang:main Feb 3, 2024
@shipurjan shipurjan deleted the add-lyrics-editor-zoom-feat branch February 4, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants