Word generation now defaults to generating 3 syllables #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travi
requested changes
Jul 27, 2017
package.json
Outdated
| @@ -48,6 +48,7 @@ | |||
| "babel-plugin-transform-exponentiation-operator": "6.24.1", | |||
| "babel-preset-es2015-node": "6.1.1", | |||
| "babel-preset-es2015-rollup": "3.0.0", | |||
| "babel-preset-stage-3": "^6.24.1", | |||
There was a problem hiding this comment.
this should be an exact version. i must not have an .npmrc file that specifies that. mind adding one as part of this PR?
|
Well shoot. Will have to dig in a bit it looks like. The line this is failing on now is the line where I used destructuring. |
|
Happy to help take a look when i get in if you haven't already sorted it out. Without looking at the build output again, the one thing I'd check is if the babel preset was applied to the rollup config. |
added 2 commits
July 28, 2017 10:00
Previously issues were being caused by times when keys were being generated as `id` for example.
This caused issues when wanting to do things like `{[any.word()]: any.string(), id:
any.simpleObject()}` as the desired 'id' key would get stomped.
travi
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.