fix(word): Fixed issue with passing length to any.word
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevtrich
force-pushed
the
default-word
branch
from
316edd9 to
8f51ba7
Compare
travi
reviewed
Aug 11, 2017
any.js
Outdated
| const sentence = options => chance.sentence(options); | ||
| const paragraph = options => chance.paragraph(options); | ||
| const url = options => chance.url(options); | ||
| const boolean = options => chance.bool(options); | ||
| const email = options => chance.email(options); | ||
| const date = () => chance.date({string: true}); | ||
|
|
||
| function word(options) { | ||
| return options && options.length ? chance.word(options) : chance.word({syllables: 3, ...options}); |
There was a problem hiding this comment.
Rather than checking if options are provided, it might be better to default options to an empty object in the signature
Since we started defaulting to passing syllables we broke the ability to pass `length` as `chance.word` does not allow passing both length & syllables. - closes travi#246
trevtrich
force-pushed
the
default-word
branch
from
8f51ba7 to
e96b53f
Compare
travi
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we started defaulting to passing syllables we broke the ability to pass
lengthaschance.worddoes not allow passing both length & syllables.