Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest better wording for 'inside a custom script' #2700

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Suggest better wording for 'inside a custom script' #2700

merged 1 commit into from
Feb 27, 2020

Conversation

shaleh
Copy link
Contributor

@shaleh shaleh commented Feb 26, 2020

The origin text

Using exit inside a custom script which will be invoked from during a build is fine.

is confusing to read because it appears to either be missing words or to be the left over from a previous edit. "invoke from during" is not standard English usage.

This PR updates the text to indicate that using exit is safe and that it will have the expected result of marking the task as failed.

@muizzk muizzk requested a review from Pezi777 February 26, 2020 22:37
@muizzk
Copy link
Contributor

muizzk commented Feb 26, 2020

Thanks @shaleh

@udeathstarck
Copy link

Deleted

Copy link
Contributor

@Pezi777 Pezi777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @shaleh for clarifying

@Pezi777 Pezi777 merged commit 95c70a8 into travis-ci:master Feb 27, 2020
gitandhub1 pushed a commit to gitandhub1/docs-travis-ci-com that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants