Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PR clones shallow and don't clone the branch first #1020

Closed
wants to merge 1 commit into from

Conversation

aidanhs
Copy link

@aidanhs aidanhs commented Apr 13, 2017

Interim fix for travis-ci/travis-ci#7589. Read that issue for background on the approach here. This PR

  • stops travis cloning a branch we don't care about before cloning the actual PR ref
  • makes sure PR cloning obeys the depth configuration
  • fixes an issue that made Display last GitHub status message if cloning fails #929 not work (I think?) because it specified assert on the command before the conditional

@aidanhs
Copy link
Author

aidanhs commented May 15, 2017

Rebased and seems to be failing on

rake aborted!
Could not find releases for tools/godep
/home/travis/build/travis-ci/travis-build/Rakefile:71:in `latest_release_for'
/home/travis/build/travis-ci/travis-build/Rakefile:148:in `block in <top (required)>'
Tasks: TOP => default => update_static_files => public/files/godep_darwin_amd64

which I don't think is my fault?

@aidanhs aidanhs force-pushed the aphs-shallow-pr branch from 7271f08 to 17aa4e1 Compare May 16, 2017 00:42
@aidanhs
Copy link
Author

aidanhs commented May 16, 2017

Forced a rebuild, seems fine now. Any chance of this getting a look at some point? We're seeing network failures on initial clone (over at the Rust repo) that would likely be solved (or at least mitigated) by this.

@meatballhat
Copy link
Contributor

@aidanhs Hello and sorry about the very long delay ❤️ ! Assuming this work is still relevant and desired, are you willing to take a crack at resolving the conflicts?

@meatballhat
Copy link
Contributor

I'm closing this out given the conflicts, and I'm not sure it's still applicable work. Please holler if you would like to see this PR reopened 💖 !

@meatballhat meatballhat closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants