Add yarn support #895

BanzaiMan · 2016-11-17T19:16:55Z

This PR adds yarn support to Travis CI.

How Yarn support works

Yarn usage detection

If both packag.json and yarn.lock file exist in the repository root, we activate yarn support.

If yarn.lock exists but the defined Node.js version does not meet the minimum requirement for Yarn (versions less than 4), we fall back to the default npm install.

Making the `yarn` command available

During the default install phase, if the yarn command is not available, it is installed with the following command, as described in https://yarnpkg.com/en/docs/install#alternatives-tab:

curl -o- -L https://yarnpkg.com/install.sh | bash

This is much faster on OS X/macOS than the documented brew update && brew install yarn, and as fast as (or slightly faster than) installing it via apt-get install on Ubuntu.

If repositories are already installing yarn in some way during the before_install or the overridden install, the installation will not take place (because yarn is available in the former case, and our installation steps will not take place in the latter case).

Caching

This PR also defines a new cache directive:

cache: yarn

or, equivalently, with other cache directives:

cache:
  yarn: true
  bundler: true
  directories:
    - node_modules

Daniel15 · 2016-11-17T19:20:34Z

Awesome, thank you @BanzaiMan! 😄

lib/travis/build/script/node_js.rb

@@ -169,6 +194,12 @@ def setup_npm_cache
          def iojs_3_plus?
            (config[:node_js] || '').to_s.split('.')[0].to_i >= 3
          end
+
+          def install_yarn
+            sh.cmd    "curl -o- -L https://yarnpkg.com/install.sh | bash", echo: true


BanzaiMan · 2016-11-17T19:26:07Z

I should add that the cache directive will cache $HOME/.yarn-cache, and that we modify $PATH to include $HOME/.yarn/bin.

To correspond with travis-ci/travis-build#895

BanzaiMan · 2016-11-17T19:49:53Z

Documentation PR is travis-ci/docs-travis-ci-com#811.

jaumard · 2016-11-18T11:10:55Z

The problem by using yarn.lock is that project who don't put this file under versioning will not be able to use yarn at all :(

Use case : a node framework that want to test his installation with npm and yarn will not be able to do it, with Trails framework we want to test installations and generators with both.

A packageManager: npm/yarn field on travis.yml would be also great.

Anyway, thanks for your great job !! :D

BanzaiMan · 2016-11-18T12:18:13Z

@jaumard Could you elaborate on what you are asking? If there is no yarn.lock in the repository root and you still want to use yarn, you can always override the install phase to use yarn. You'd still need to install yarn until we roll out images that have it pre-installed, but I tend to think this is an unusual use case. Am I mistaken?

Even when `yarn.lock` is present, if Node.js requirement is not met, we fall back to the default `npm install` command.

To correspond with travis-ci/travis-build#895

jaumard · 2016-11-18T12:50:28Z

@BanzaiMan of course we can always override install phase but I think it will be better/easier/natural to just have a field to choose witch package manager we want like we choose the node versions or os.

this is an unusual use case

Yes and no if all library/frameworks/generators modules want to test yarn and npm install it will be a lot of cases ^^

joshk

This looks fantastic, big 👍 from me!

BanzaiMan · 2016-11-18T14:21:06Z

We will consider package_manager key for future enhancement.

We will deploy this Monday next week.

BanzaiMan · 2016-11-18T14:24:59Z

By the way, you can see the test here: https://staging.travis-ci.org/BanzaiMan/example-yarn-package/builds/525479

mattgrande · 2016-11-18T17:09:46Z

I just had a build complete (node 6.9.1, yarn.lock file present) and I noticed that it still used npm install.

As I'm typing this, I'm noticing that this was just merged in three hours ago... Can I assume this is still being rolled out, and my builds will eventually use yarn, as it becomes available?

SpaceK33z · 2016-11-18T17:11:54Z

We will deploy this Monday next week.

see above

mattgrande · 2016-11-18T17:13:42Z

Missed that; thanks.

lib/travis/build/script/node_js.rb

@@ -41,7 +41,20 @@ def announce

        def install
          sh.if '-f package.json' do
-            sh.cmd "npm install #{config[:npm_args]}", retry: true, fold: 'install'
+            sh.if "-f yarn.lock" do
+              if version.to_i < 4


jdevalk · 2016-11-21T11:15:32Z

Is deploy still planned for today?

joshk · 2016-11-21T11:16:46Z

@jdevalk that is the plan :)

Hiro lives on the East Coast, so will be online soon to start the roll out.

jdevalk · 2016-11-21T14:05:19Z

Awesome, I hope @BanzaiMan will update us when it's live :D my builds are waiting ;)

ai · 2016-11-21T14:07:30Z

Agree, let's merge current patch and then will improve it in other PRs. I soooo waiting yarn support without long before_install scripts 😊

* build: cleanup travis ci setup * travis-ci/travis-build#895 * Fix that Travis doesn't show if the tests failed * Cleanup browser providers * Update karma version * Properly report exit code to gulp * Return error * That's it

lib/travis/build/script/node_js.rb

+          if data.cache?(:yarn)
+            sh.fold 'cache.yarn' do
+              sh.echo ''
+              directory_cache.add '$HOME/.yarn-cache'


BanzaiMan and others added 4 commits November 16, 2016 14:25

Add yarn support

305e632

Skip installing yarn if it's available

8b08bca

Touch up yarn messages

40d603b

Auto-merged master into ha-yarn on deployment.

6dcb4ba

BanzaiMan mentioned this pull request Nov 17, 2016

Add support for yarn travis-ci/travis-ci#6720

Closed

Daniel15 reviewed Nov 17, 2016

View reviewed changes

BanzaiMan added a commit to travis-ci/docs-travis-ci-com that referenced this pull request Nov 17, 2016

Document yarn support

f71196f

To correspond with travis-ci/travis-build#895

BanzaiMan mentioned this pull request Nov 17, 2016

Document yarn support travis-ci/docs-travis-ci-com#811

Merged

jaumard mentioned this pull request Nov 18, 2016

Trails should be tested with yarnpkg in addition to npm trailsjs/trails#249

Open

BanzaiMan added 2 commits November 18, 2016 07:36

Fall back to default "npm install" Node.js < 4

c7e28ff

Even when `yarn.lock` is present, if Node.js requirement is not met, we fall back to the default `npm install` command.

Merge branch 'ha-yarn' of github.com:travis-ci/travis-build into ha-yarn

2d5e4d0

BanzaiMan added a commit to travis-ci/docs-travis-ci-com that referenced this pull request Nov 18, 2016

Document yarn support

e4eb11d

To correspond with travis-ci/travis-build#895

Auto-merged master into ha-yarn on deployment.

bc407b9

BanzaiMan deployed to org-staging November 18, 2016 13:59 Active

joshk approved these changes Nov 18, 2016

View reviewed changes

joshk merged commit 67955fc into master Nov 18, 2016

PierreBesson mentioned this pull request Nov 18, 2016

[Feature] Official support for Yarn jhipster/generator-jhipster#4317

Closed

3 tasks

BanzaiMan commented Nov 19, 2016

View reviewed changes

nickytonline mentioned this pull request Nov 19, 2016

Update Travis CI configuration coryhouse/react-slingshot#323

Closed

luclu mentioned this pull request Nov 21, 2016

Replace npm shrinkwrap with yarn.lock ethereum/mist#1278

Merged

devversion added a commit to devversion/flex-layout that referenced this pull request Jan 13, 2017

https://github.com/travis-ci/travis-build/pull/895

2711e60

zupo reviewed Sep 5, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add yarn support #895

Add yarn support #895

BanzaiMan commented Nov 17, 2016 •

edited

Loading

Daniel15 commented Nov 17, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

BanzaiMan commented Nov 17, 2016

BanzaiMan commented Nov 17, 2016

jaumard commented Nov 18, 2016

BanzaiMan commented Nov 18, 2016 •

edited

Loading

jaumard commented Nov 18, 2016 •

edited

Loading

joshk left a comment

BanzaiMan commented Nov 18, 2016 •

edited

Loading

BanzaiMan commented Nov 18, 2016

mattgrande commented Nov 18, 2016

SpaceK33z commented Nov 18, 2016

mattgrande commented Nov 18, 2016

This comment was marked as spam.

This comment was marked as spam.

jdevalk commented Nov 21, 2016

joshk commented Nov 21, 2016

jdevalk commented Nov 21, 2016

ai commented Nov 21, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Add yarn support #895

Add yarn support #895

Conversation

BanzaiMan commented Nov 17, 2016 • edited Loading

How Yarn support works

Yarn usage detection

Making the yarn command available

Caching

Daniel15 commented Nov 17, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

BanzaiMan commented Nov 17, 2016

BanzaiMan commented Nov 17, 2016

jaumard commented Nov 18, 2016

BanzaiMan commented Nov 18, 2016 • edited Loading

jaumard commented Nov 18, 2016 • edited Loading

joshk left a comment

Choose a reason for hiding this comment

BanzaiMan commented Nov 18, 2016 • edited Loading

BanzaiMan commented Nov 18, 2016

mattgrande commented Nov 18, 2016

SpaceK33z commented Nov 18, 2016

mattgrande commented Nov 18, 2016

This comment was marked as spam.

This comment was marked as spam.

jdevalk commented Nov 21, 2016

joshk commented Nov 21, 2016

jdevalk commented Nov 21, 2016

ai commented Nov 21, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

BanzaiMan commented Nov 17, 2016 •

edited

Loading

Making the `yarn` command available

BanzaiMan commented Nov 18, 2016 •

edited

Loading

jaumard commented Nov 18, 2016 •

edited

Loading

BanzaiMan commented Nov 18, 2016 •

edited

Loading