Calculate travel_offset to align with the precision of argument to Timecop.travel #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgholz
force-pushed
the
align_subsec_on_nanoseconds
branch
from
7b8921f
to
5dcbc68
Compare
Subtracting two `Time`s returns a `Float`, which may not be accurate down to subsecond resolution. Because `Float`s are stored as double- precision values (IEEE 754), they can have resolutions much higher than the typical minimum clock precision of 10e-9 seconds. Which can result in two `Time` object not comparing as equal when they are the same down to the nanosecond, when one has had a travel_offset applied to it.
dgholz
force-pushed
the
align_subsec_on_nanoseconds
branch
from
5dcbc68
to
2906ca3
Compare
dgholz
changed the title
dgholz
changed the title
dgholz
force-pushed
the
align_subsec_on_nanoseconds
branch
from
2906ca3
to
c2bdfc7
Compare
|
@joshuacronemeyer I'd greatly appreciate your opinion on this PR, if you have the time. |
|
@joshuacronemeyer I still think this change has a significant benefit to users & would appreciate your opinions on it |
|
@dgholz thank you for your detailed issue and for this PR. I was spaced out i guess when this came in, so thanks for bringing it to my attention. I will try to look at this soon. |
|
Looks good! |
|
@dgholz I reverted this because of a failing test. Happy to look at it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtracting two
Times returns aFloat, which may not be accurate down to subsecond resolution. BecauseFloats are stored as double-precision values (IEEE 754), they can have resolutions much higher than the typical minimum clock precision of 10e-9 seconds. Which can result in twoTimeobject not comparing as equal when they are the same down to the nanosecond, when one has had atravel_offsetapplied to it.To fix #420.