fix: disallow empty groupings #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Then you need to |
|
See #42 |
|
Yeah I'll just wait for that one to merge then rebase |
ribru17
force-pushed
the
no_empty_groupings
branch
from
0f6f3c6 to
63e0cb9
Compare
Something like `()` or `[]` is a syntax error and it would be nice if the parser reflected that (even if just with a "missing" node rather than an error node).
ribru17
force-pushed
the
no_empty_groupings
branch
from
63e0cb9 to
3b59901
Compare
amaanq
approved these changes
Nov 9, 2024
For the record, that goes against the general policy that tree-sitter parsers should not try to be linters. (And the breakage in nvim-treesitter shows why...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something like
()is a syntax error and it would be nice if the parser reflected that (even if just with a "missing" node rather than an error node).ts gran with 0.24.3