fix grammar when character class is only a range #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change a character class such as
[0-1]
was parsed as:So the range was completely dropped. This happened for two reasons:
class_range
which dispatched directly to_class_atom
, which did more work than was strictly necessary to match a class character.character_class
overclass_range
.After fixing the issues above I now get:
While still accepting expressions such as
[-0-1-]
(optional-
on each end).Note: this approach does generate slightly larger tables due to hoisting the
-
optional check to thecharacter_class
production, but it seems like a reasonable tradeoff to get correct behavior.