Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of multiple unicode escapes #258

Merged
merged 1 commit into from
May 21, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented May 21, 2024

@hvitved
Copy link
Contributor Author

hvitved commented May 21, 2024

cc @amaanq .

@amaanq
Copy link
Member

amaanq commented May 21, 2024

thank you, sorry about that! though the test diff is huge - i know ts t -u will format all the tests if they're not, but can you just manually update the test(s) that changed?

@hvitved
Copy link
Contributor Author

hvitved commented May 21, 2024

can you just manually update the test(s) that changed?

Is it OK to leave as-is (I have a commit in another repo that refers to the SHA from this PR)? The only change I made to the test corpus was the addition of two new lines.

@amaanq
Copy link
Member

amaanq commented May 21, 2024

Yeah it's totally fine - I was just curious what test actually got updated

@amaanq amaanq merged commit b41dc0f into tree-sitter:master May 21, 2024
4 checks passed
@hvitved hvitved deleted the fix-multiple-unicode branch May 21, 2024 13:13
@hvitved hvitved restored the fix-multiple-unicode branch May 21, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants