Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I really need minimal x-platform download progress for a project. To my knowledge no nim lib exists that allows this, but puppy is the closest. It would be ideal to also implement upload progress, but I figure one thing at a time. Also, download progress is far more common of a need than upload progress -- so a phased development doesn't seem horrible.
What's working in this PR:
libcurl
download progress callbackWinHTTP
download progress callbackWhat's broken:
Instead of including my attempt for macOS, I've left it untouched. This means it will not compile right now due to breaking signature changes elsewhere.
Features:
Assumptions:
What needs help or guidance:
NSURLConnectionDelegate
type?It looks like everything necessary is there to make this relatively easy. I have some guesses about how to use the templates, but there's a complex dance of declarations and registrations that needs to happen, and I'm at a loss. So far I've been looking into other delegate wrappers for understanding, like in the older nim objc project by jangko, and rust's objc wrapper.
ProgressCallback
? I don't like how long it is, but it is at least descriptive.