Re-open control connection after it closes, and add timeouts #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add much shorter LDAP timeouts to the control connection so users do not need to wait for minutes to fail to login. The control connection may close at any time, because TCP. When it does re-open it on the *next* connection attempt. (The first attempted login after being disconnected may fail. I consider this a feature because it will rarely happen, the user will try again to login, and if the attempt just made is what caused the server to fail then we should give the user some feedback.) Fixes #2606.
Not on configuration because of impossibility to set default values on optional subobjects when using viper. Defer on this until a real user requirement for this shows up.
arielshaqed
added
the
include-changelog
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add much shorter LDAP timeouts to the control connection so users do not
need to wait for minutes to fail to login.
The control connection may close at any time, because TCP. When it does
re-open it on the next connection attempt. (The first attempted login
after being disconnected may fail. I consider this a feature because it
will rarely happen, the user will try again to login, and if the attempt
just made is what caused the server to fail then we should give the user
some feedback.)
Fixes #2606.