Rotating-file stream prevent process from exiting #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rotation `setTimeout` from `RotatingFileStream` will prevent the process from exiting. This fix simply `unref()` the timeout immediately after it is set.
Will fail if any timers or callbacks remain registered when instantiating a logger with a rotating file.
|
+1 I ran into this issue as well and the unref works well |
trentm
added a commit
that referenced
this pull request
Jun 1, 2014
Rotating-file stream prevent process from exiting
|
Thanks very much for this. I apologize for taking so long to get to this. This will be in bunyan 0.23.1. |
|
Thanks! On Sun, Jun 1, 2014 at 1:29 AM, Trent Mick notifications@github.com wrote:
Jeff Barczewski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of pull request #97
Merged with latest trentm/node-bunyan master.
Includes test case.