Update CRAN version of shinyAce #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for looking at this! I just submitted a PR to your branch that will clean up a few remaining loose ends and will hopefully be good enough to get back onto CRAN. Let me know if the stacked PR thing causes problems. If so I can just close this and merge my branch that includes these fixes. |
Clean up remaining warning
trestletech
added a commit
that referenced
this pull request
Feb 4, 2016
Update CRAN version of shinyAce
|
I'm going to let this soak for a couple of days to make sure nobody reports any show-stopping issues. But if you haven't heard back from me by early next week, feel free to ping me on this again and we'll try to get it up on CRAN next week. Thanks again! |
|
Excellent! Thanks Jeff. |
|
You said to ping you so ... ping. Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address the concerns listed in issue #26. The remaining notes from R-check (3.2.3) are:
installed size is 9.9Mb
sub-directories of 1Mb or more:
www 9.7Mb
Unexported object imported by a ':::' call: ‘utils:::.win32consoleCompletion’
See the note in ?
:::about the use of this operator.