Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow puppetlabs/firewall 8.x #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jhoblitt
Copy link
Contributor

@jhoblitt jhoblitt commented Sep 7, 2024

No description provided.

@jhoblitt
Copy link
Contributor Author

jhoblitt commented Sep 7, 2024

I believe the CI failure(s) are unrelated to the PR.

    Problem: package perfsonar-toolkit-5.1.2-1.el8.noarch from perfSONAR requires perfsonar-core, but none of the providers can be installed
    - package perfsonar-core-5.1.2-1.el8.noarch from perfSONAR requires perfsonar-testpoint, but none of the providers can be installed
    - package perfsonar-testpoint-5.1.2-1.el8.noarch from perfSONAR requires httpd-wsgi-socket, but none of the providers can be installed
    - cannot install the best candidate for the job
    - nothing provides mod_wsgi needed by httpd-wsgi-socket-1.0-1.el8.4261.77c636c73c9f8535e20ed171f070cf5057242ea4.noarch from perfSONAR
    - nothing provides mod_wsgi needed by httpd-wsgi-socket-1.0-1.el8.noarch from perfSONAR

@jhoblitt jhoblitt force-pushed the IT-5559/allow-firewall-8.x branch from 5e427d3 to fba4701 Compare September 7, 2024 01:45
@treydock
Copy link
Owner

The unit tests need updates to account for different firewall property being used.

@treydock
Copy link
Owner

Ah, update .fixtures.yml to not pin to 6.0.0, I think that's why the unit tests are failing.

@treydock treydock added the enhancement New feature or request label Oct 11, 2024
@jhoblitt jhoblitt force-pushed the IT-5559/allow-firewall-8.x branch 2 times, most recently from 55676f4 to a5f7208 Compare October 11, 2024 16:21
@jhoblitt
Copy link
Contributor Author

I think the provider metaparam went away in >= 7.0.0: https://github.com/puppetlabs/puppetlabs-firewall/blob/main/CHANGELOG.md#v700---2023-09-13

@jhoblitt
Copy link
Contributor Author

EL8 is still broken:

    Problem: package perfsonar-toolkit-5.1.2-1.el8.noarch from perfSONAR requires perfsonar-core, but none of the providers can be installed
    - package perfsonar-core-5.1.2-1.el8.noarch from perfSONAR requires perfsonar-testpoint, but none of the providers can be installed
    - package perfsonar-testpoint-5.1.2-1.el8.noarch from perfSONAR requires httpd-wsgi-socket, but none of the providers can be installed
    - cannot install the best candidate for the job
    - nothing provides mod_wsgi needed by httpd-wsgi-socket-1.0-1.el8.4261.77c636c73c9f8535e20ed171f070cf5057242ea4.noarch from perfSONAR
    - nothing provides mod_wsgi needed by httpd-wsgi-socket-1.0-1.el8.noarch from perfSONAR

I don't need to support pS on EL8. I don't suppose this module could just drop support for it? Otherwise, the acceptance tests probably need to setup additional yum repos for EL8.

@treydock
Copy link
Owner

Looks like PerfSONAR repos are broken for EL8. My EL8 perfSonar server has the mod_wsgi RPM from when it was provisioned using PerfSONAR repos but now the RPM is missing.

@treydock
Copy link
Owner

I'll merge even with EL8 failure. I'm working on some stdlib 9.x support I need to release first as I'm not quite ready to jump to firewall >= 7.0. Doing stdlib 9.x upgrade first.

manifests/firewall.pp Outdated Show resolved Hide resolved
manifests/firewall.pp Outdated Show resolved Hide resolved
Resolves this warning:

    Warning: /etc/puppetlabs/code/modules/perfsonar/data/common.yaml: file does not contain a valid yaml hash
@jhoblitt jhoblitt force-pushed the IT-5559/allow-firewall-8.x branch from fd85a67 to 241848f Compare October 14, 2024 18:16
@jhoblitt jhoblitt requested a review from treydock October 14, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants