-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow puppetlabs/firewall 8.x #26
base: master
Are you sure you want to change the base?
Conversation
I believe the CI failure(s) are unrelated to the PR.
|
5e427d3
to
fba4701
Compare
The unit tests need updates to account for different firewall property being used. |
Ah, update |
55676f4
to
a5f7208
Compare
I think the provider metaparam went away in >= 7.0.0: https://github.com/puppetlabs/puppetlabs-firewall/blob/main/CHANGELOG.md#v700---2023-09-13 |
EL8 is still broken:
I don't need to support pS on EL8. I don't suppose this module could just drop support for it? Otherwise, the acceptance tests probably need to setup additional yum repos for EL8. |
Looks like PerfSONAR repos are broken for EL8. My EL8 perfSonar server has the mod_wsgi RPM from when it was provisioned using PerfSONAR repos but now the RPM is missing. |
I'll merge even with EL8 failure. I'm working on some stdlib 9.x support I need to release first as I'm not quite ready to jump to firewall >= 7.0. Doing stdlib 9.x upgrade first. |
Resolves this warning: Warning: /etc/puppetlabs/code/modules/perfsonar/data/common.yaml: file does not contain a valid yaml hash
fd85a67
to
241848f
Compare
No description provided.