fix(fw): handle signed tags in releases-json.py #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we ever use signed tags? 👀 |
|
I'm signing them, IIRC you asked me to do it. Version 2.6.0 seems to be the first signed one. |
yeah, it's possible.
very cool then! |
matejcik
approved these changes
Nov 11, 2024
|
FWIW since 2.6.0 about 60 % of the tags are signed and nobody seems to care, but I suppose it won't hurt anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed tags have their own SHA and need one more dereference to get to the commit SHA.