This repository has been archived by the owner on May 28, 2019. It is now read-only.
xmr: payment ID computation fix #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- typo in tail differentiating tag caused invalid short payment id encryption. was 0x8B, should have been 0x8D - https://github.com/monero-project/monero/blob/69b646494b17a02e381128e54caebccf2d2b7729/src/device/device_default.cpp#L39 - https://github.com/monero-project/monero/blob/69b646494b17a02e381128e54caebccf2d2b7729/src/device/device_default.cpp#L287
|
Tests fixed too, pls re-run Travis |
31 tasks
This was referenced Nov 28, 2018
|
Mitigation implemented in monero-project/monero#4839 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo in tail differentiating tag caused invalid short payment id encryption. was 0x8B, should have been 0x8D.
Correct computation:
Tail tag
0x8Dwas mistyped as0x8Bwhich yields a different hash which is used for XOR.No funds are lost, but payment ID is incorrect which can cause payment linking problems when using exchanges / markets.
Recipient of the message can recompute the payment ID:
OR from the wrongly decrypted plain payment id:
Demonstration code that decodes payment ID correctly, takes transaction ID and secret view key:
https://gist.github.com/ph4r05/b95c085b101cd9c9ba5dad104dfab007
The PR will be added to the Monero-wallet-cli which will check for firmware version and block transactions with short payment IDs if the firmware version is <=2.0.9. Stay tuned.
Sources: