Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate firmware for T1 #1084

Merged
merged 25 commits into from
Aug 21, 2020
Merged

Intermediate firmware for T1 #1084

merged 25 commits into from
Aug 21, 2020

Conversation

hiviah
Copy link
Contributor

@hiviah hiviah commented Jun 25, 2020

Implementation for issue #4 .

There is also script in script/cibuild_intermediate_fw for CI build.

@hiviah hiviah requested a review from prusnak June 25, 2020 16:14
@hiviah hiviah requested a review from tsusanka as a code owner June 25, 2020 16:14
@tsusanka
Copy link
Contributor

tsusanka commented Jun 28, 2020

🎉

I will leave the bootloader review for @prusnak but ping me if I should help. I have currently two questions:

  1. I guess let's add the CI build script into our CI? See below.
  2. Is it a good idea to version it as 1.9.1? Shouldn't we version it as a standalone project maybe? Something to discuss with @prusnak.
legacy intermediary fw build:
  stage: build
  script:
    - cd legacy
    - pipenv run script/cibuild_intermediate_fw
    - cd ..
    - export VERSION=$(./tools/version.sh legacy/intermediate_fw/version.h)
    - mv legacy/firmware/trezor.bin trezor-intermediary-fw-$VERSION-$CI_COMMIT_SHORT_SHA.bin  # is this correct? is the source indeed trezor.bin?
  artifacts:
    name: "$CI_JOB_NAME-$CI_COMMIT_SHORT_SHA"
    paths:
    - trezor-intermediary-fw-*.*.*-$CI_COMMIT_SHORT_SHA.bin
    expire_in: 1 week

@tsusanka tsusanka removed their request for review June 28, 2020 11:11
@prusnak prusnak added this to the backlog milestone Jul 22, 2020
@prusnak prusnak modified the milestones: backlog, 2020-09 Aug 4, 2020
@tsusanka
Copy link
Contributor

tsusanka commented Aug 18, 2020

Ping @prusnak it would be great to move this forward a bit.

@tsusanka tsusanka modified the milestones: 2020-09, 2020-10 Aug 19, 2020
@prusnak prusnak merged commit ff3b10a into master Aug 21, 2020
@prusnak prusnak deleted the omikle/t1-intermediate-fw branch August 21, 2020 12:58
@tsusanka tsusanka modified the milestones: 2020-10, 2020-11 Oct 1, 2020
@tsusanka tsusanka modified the milestones: 2020-11, 2020-12 Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants