Extra BIP32 test (new test vector #4) #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optout21
changed the title
|
For the reference, suggested test vector is not yet merged into the BIP32, but it will be a matter of days before it does. It got several high-profile ACKs already - see bitcoin/bips#1030 |
|
@catenocrypt can you please add the test for path m/0H/1H as well? It is included in the test vector, but not included in your code. |
I have included this too now. The existing vector 1--3 do not include all paths, that's why I have not included all. |
prusnak
approved these changes
Jun 3, 2021
andrewkozlik
approved these changes
Jun 3, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was found with some BIP32 implementation, causing incorrect keys with certain seeds (starting with zeroes), see
https://blog.polychainlabs.com/bitcoin,/bip32,/bip39,/kdf/2021/05/17/inconsistent-bip32-derivations.html
Trezor implementation is not affected.
Nonetheless the newly added test vector can be included as an extra test (BIP32 test vector #4).
Test vector 4 is being added to the BIP32 BIP here:
bitcoin/bips#1030