Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public key from the ed25519 signing API #2349

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Remove public key from the ed25519 signing API #2349

merged 1 commit into from
Jun 27, 2022

Conversation

andrewkozlik
Copy link
Contributor

Resolves #2338.

kchalkias
kchalkias approved these changes Jun 24, 2022
View reviewed changes
Copy link

@kchalkias kchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great work and blazing fast response!

prusnak
prusnak approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andrew

@andrewkozlik andrewkozlik removed the request for review from onvej-sl June 27, 2022 16:49
@andrewkozlik andrewkozlik merged commit 892f3e3 into master Jun 27, 2022
@andrewkozlik andrewkozlik deleted the andrewkozlik/donna branch June 27, 2022 16:59
@trezor trezor deleted a comment from kchalkias Jun 27, 2022
@prusnak prusnak mentioned this pull request Jul 7, 2022
Closed
@hewigovens hewigovens mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchalkias kchalkias kchalkias approved these changes

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

potential ed25519 unsafe signing
3 participants
@andrewkozlik @prusnak @kchalkias