Skip to content
This repository has been archived by the owner on Apr 16, 2019. It is now read-only.

Commit

Permalink
support full 32bit chain_id
Browse files Browse the repository at this point in the history
  • Loading branch information
hackmod committed Jul 22, 2018
1 parent 1c81a14 commit 3b5419f
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions firmware/ethereum.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@
#include "memzero.h"
#include "messages.pb.h"

/* maximum supported chain id. v must fit in an uint32_t. */
#define MAX_CHAIN_ID 2147483630

static bool ethereum_signing = false;
static uint32_t data_total, data_left;
static EthereumTxRequest msg_tx_request;
Expand Down Expand Up @@ -461,7 +458,7 @@ void ethereum_signing_init(EthereumSignTx *msg, const HDNode *node)

/* eip-155 chain id */
if (msg->has_chain_id) {
if (msg->chain_id < 1 || msg->chain_id > MAX_CHAIN_ID) {
if (msg->chain_id < 1) {
fsm_sendFailure(Failure_FailureType_Failure_DataError, _("Chain Id out of bounds"));
ethereum_signing_abort();
return;
Expand Down

0 comments on commit 3b5419f

Please sign in to comment.