feat(connect-cardano): allow external reward addresses in governance registrations

[davidmisiak]

The corresponding firmware PR is here. Changes in Cardano CIP-36 vote key registrations:

• The address to receive voting rewards can be provided as an address string (paymentAddress) instead of address parameters.

• Renamed identifiers (initiated by clarifications in CIP-36, context e.g. here and here):

  • governance replaced by cVote (all occurences)
  • rewardAddressParameters replaced by paymentAddressParameters
  • votingPublicKey replaced by votePublicKey

  The changes are also present in the public API, but I kept silent support for the old names, like we did in feat(cardano): add support for CIP-36 Catalyst registration format #6735 when we replaced catalyst by governance (I know that the renaming frequency is a bit unfortunate, but the Cardano terminology seems to be still evolving). Is this alright or would you prefer a different solution?

[mroz22]

Hi, thanks for contribution, we are looking into this PR now.

I'd stick to keeping old namings along with the new ones. In general, we should avoid breaking changes here.

[mroz22]

Hi @davidmisiak I couldn't spot any issues here so it looks like it is ready to merge

Just let me ask, do you have any testing environment where @trezor/qa could test this prior to release/

[davidmisiak]

Thanks for processing the PR!

Just let me ask, do you have any testing environment where @trezor/qa could test this prior to release/

I'm not sure what kind of environment do you mean. We usually test the changes in Trezor Firmware and Connect in cardano-hw-cli. We will update hw-cli to use a build of Connect with the changes from this PR in the following days/weeks (though the changes are rather minor and mostly in naming). Is this something that could be useful to you?