Removed redundant "git-subrepo" folder #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the empty and redundant folder "/deps/git-subrepo".
Updated the db_characters SQL files relating to NPC Bots. - Updated charset to utf8mb4. - Added collate utf8mb_unicode_ci. - Added comments. - Replaced /custom SQL files with top level SQL files.
|
There are a few problems with these changes.
I don't ask you to roll back your changes as I understand you share the work you made in your fork but I appreciate the suggestions anyway, I'll pick them manually, hope you don't mind. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the redundant
/deps/git-subrepofolder.I have omitted the pull request template due the simplicity of this change.