Add locking feature to prevent stale code #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rondale-sc
force-pushed
the
lock_steady
branch
from
bea91e8
to
964ae7d
Compare
rwz
force-pushed
the
lock_steady
branch
5 times, most recently
from
4f111ea
to
9f83a8d
Compare
| $ npm install --save-dev ember-cli-rails-addon@#{ADDON_VERSION}` | ||
|
|
||
| in you Ember application root: #{app_path} | ||
| MSG |
|
LGTM |
| def check_addon! | ||
| dependencies = package_json.fetch("devDependencies", {}) | ||
|
|
||
| unless dependencies["ember-cli-rails-addon"] == ADDON_VERSION |
There was a problem hiding this comment.
We also need to check for EmberCLI version. It must be greater than 1.3.0 in order to have the preBuild hook that the addon needs.
There was a problem hiding this comment.
I am unsure that you should care too much about this here. You can make the addon check the required version var version = this.project.emberCLIVersion(); and it can be kept with a nice message. Then here (in ember-cli-rails) you just don't have to care about it.
rwz
added a commit
that referenced
this pull request
Dec 19, 2014
Add locking feature to prevent stale code
|
WOOT, awesome job y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds locking feature that works with ember-cli-rails-addon (the companion addon in node land)
The
ember-cli-rails-addonuses thepreBuildhook to write a file calledpreBuild.lockto the output and thepostBuildhook to delete that file and writepostBuild.lockThe middleware we are now injecting blocks until the
preBuildfile is not found and thepostBuildis found before continuing the request. This results in a block until ember-cli has fully built the output.Cheers 🍺