Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade redpanda #51

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Feature/upgrade redpanda #51

merged 3 commits into from
Feb 2, 2024

Conversation

cthtrifork
Copy link
Contributor

No description provided.

Copy link

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH shellcheck 5 0 0.15s
⚠️ BASH shfmt 5 1 0.0s
✅ COPYPASTE jscpd yes no 1.18s
✅ DOCKERFILE hadolint 1 0 0.08s
✅ JSON eslint-plugin-jsonc 5 0 1.55s
✅ JSON jsonlint 4 0 0.22s
⚠️ JSON prettier 4 1 1.37s
✅ JSON v8r 4 0 2.34s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY grype yes no 10.19s
✅ REPOSITORY trivy yes no 5.4s
✅ REPOSITORY trivy-sbom yes no 4.04s
✅ REPOSITORY trufflehog yes no 7.35s
✅ YAML prettier 19 0 1.4s
✅ YAML v8r 19 0 5.67s
⚠️ YAML yamllint 19 1 0.92s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@pegtrifork
Copy link
Contributor

I still don't like having the docker network external, since most users will start by upping the developement infrastucture.
But otherwise it looks good! Since to move away from the redpanda release candidate

@cthtrifork
Copy link
Contributor Author

I still don't like having the docker network external, since most users will start by upping the developement infrastucture. But otherwise it looks good! Since to move away from the redpanda release candidate

Yeah but even readme suggests it as a prerequisite.
Hmm i guess the tradeoff depends on how often people clean their entire docker setup including networks. Do you see it as a frequent occurrence?

@cthtrifork cthtrifork merged commit 9e66cbf into main Feb 2, 2024
3 checks passed
@cthtrifork cthtrifork deleted the feature/upgrade-redpanda branch February 2, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants