Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: Changes to Import broke MMM_Timings #4381

Closed
csiefer2 opened this issue Feb 12, 2019 · 5 comments
Closed

Tpetra: Changes to Import broke MMM_Timings #4381

csiefer2 opened this issue Feb 12, 2019 · 5 comments
Assignees
@cgcgcg
Labels
pkg: Tpetra

Comments

@csiefer2
Copy link
Member

Both the changes and the MMM_Timings use "prefix" to mean different data types.
cgcgcg added a commit to cgcgcg/Trilinos that referenced this issue Feb 12, 2019
@cgcgcg
Tpetra: Fix issue trilinos#4381
e2b0c1e
@cgcgcg cgcgcg mentioned this issue Feb 12, 2019
Merged
@mhoemmen
Copy link
Contributor

@csiefer2 May I remove the MMM timings macros and just introduce timers that always exist?

@csiefer2
Copy link
Member Author

@mhoemmen I'd rather not --- Those guys do string manipulation to "nest" timer names.

Counterproposal: Add a MMM Timings option to Tpetra_Details_Behavior

@mhoemmen
Copy link
Contributor

@csiefer2 wrote:

Counterproposal: Add a MMM Timings option to Tpetra_Details_Behavior

I'm OK with this. How about TPETRA_MMM_TIMINGS?

trilinos-autotester added a commit that referenced this issue Feb 13, 2019
@trilinos-autotester
Merge Pull Request #4382 from cgcgcg/Trilinos/tpetraImportFix
db553b5 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: Tpetra: Fix issue #4381
PR Author: cgcgcg
@csiefer2
Copy link
Member Author

@mhoemmen Sounds good to me.

@cgcgcg
Copy link
Contributor

cgcgcg commented Jun 19, 2020

Fixed via #4382

@cgcgcg cgcgcg closed this as completed Jun 19, 2020
@trilinos-autotester trilinos-autotester mentioned this issue May 7, 2021
Merged
@jhux2 jhux2 added this to Tpetra Aug 12, 2024
@jhux2 jhux2 moved this to Done in Tpetra Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgcgcg cgcgcg

Labels
pkg: Tpetra
Projects
Tpetra
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mhoemmen @cgcgcg @csiefer2