Skip to content

Commit

Permalink
Use and require Java 23
Browse files Browse the repository at this point in the history
  • Loading branch information
oneonestar committed Oct 24, 2024
1 parent f05cea4 commit fd418e6
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java-version: [22, 23-ea]
java-version: [23]
timeout-minutes: 20
steps:
- name: Checkout source
Expand Down
2 changes: 1 addition & 1 deletion .java-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22
23
4 changes: 2 additions & 2 deletions docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## Build requirements

* Mac OS X or Linux
* Java 22+, 64-bit
* Java 23+, 64-bit
* Docker

#### Running Trino Gateway in your IDE
Expand All @@ -21,7 +21,7 @@ or execute the following command:

#### Locally

This project requires Java 22. Note that higher version of Java have not been
This project requires Java 23. Note that higher version of Java have not been
verified and may run into unexpected issues.

Run `./mvnw clean install` to build `trino-gateway`. VM options required for
Expand Down
2 changes: 1 addition & 1 deletion docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Consider the following requirements for your Trino Gateway installation.

### Java

Trino Gateway requires a Java 22 runtime. Older versions of Java can not be
Trino Gateway requires a Java 23 runtime. Older versions of Java can not be
used. Newer versions might work but are not tested.

Verify the Java version on your system with `java -version`.
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<project.build.targetJdk>22</project.build.targetJdk>
<air.java.version>22</air.java.version>
<project.build.targetJdk>23</project.build.targetJdk>
<air.java.version>23</air.java.version>
<air.check.skip-spotbugs>true</air.check.skip-spotbugs>
<air.check.skip-pmd>true</air.check.skip-pmd>
<air.release.preparation-goals>clean verify -DskipTests</air.release.preparation-goals>
Expand Down

3 comments on commit fd418e6

@mosabua
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we decided to release 12 first .. and then upgrade. Trino is still on 22 until 464... if we keep with it .. we should also update the dependencies and use of Trino in testing ideally.

@oneonestar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be a problem.
"Gateway on 23" can use "Trino compiled by 22" and "Trino compiled by 23".
"Gateway on 22" can use "Trino compiled by 22" but not "Trino compiled by 23".
Also it doesn't feel right to release 12 using Java22 which is already EOL.

@mosabua
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Please sign in to comment.