Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve security documentation #26

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Improve security documentation #26

merged 1 commit into from
Sep 7, 2023

Conversation

Chaho12
Copy link
Member

@Chaho12 Chaho12 commented Sep 4, 2023

  • odic -> OAuth/OpenIDConnect
    • odic is typo for oidc which means OpenIDConnect
    • Conf is set using OAuth so added example to set defaultType as OAuth to use OIDC/OAuth
  • Separated Form into basic auth and LDAP auth

@cla-bot cla-bot bot added the cla-signed label Sep 4, 2023
mosabua
mosabua reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you confirm @vishalya @andythsu @willmostly and any others?

@mosabua
Copy link
Member

mosabua commented Sep 5, 2023

Also can you change commit to

"Improve security documentation"

@Chaho12 Chaho12 force-pushed the origin/feature/jaeho.yoo/add_security_details branch from c1dfa5b to 3e9c8b3 Compare September 6, 2023 18:56
@Chaho12 Chaho12 force-pushed the origin/feature/jaeho.yoo/add_security_details branch from 3e9c8b3 to d3d734e Compare September 7, 2023 02:09
@mosabua mosabua changed the title update details on security doc Improve security documentation Sep 7, 2023
@mosabua mosabua merged commit fbfb546 into trinodb:main Sep 7, 2023
1 check passed
@Chaho12 Chaho12 deleted the origin/feature/jaeho.yoo/add_security_details branch September 7, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andythsu andythsu andythsu left review comments

@mosabua mosabua mosabua approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chaho12 @mosabua @andythsu