-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve project setup #29
Conversation
Currently there are test failures related to some classpath issues .. @willmostly and myself are looking but if anybody else wants to chime in that would help |
19a1bac
to
06f328b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor formatting issues
<build> | ||
<plugins> | ||
<plugin> | ||
<groupId>org.apache.maven.plugins</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed because we want to move to the Trino/Airlift style and validation anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, otherwise LGTM
df4c3f5
to
185d651
Compare
@mosabua can you split this PR into multiple commits? |
Not really .. this current setup is necessary for it to build. If I split it up the commits in between wont build. |
I have a script running some tasks against the gateway with changes in this PR and it seems to be running fine. It's good for me. |
Rebased #17 from main into here now .. everything still working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in a decent shape now. I am able to compile and test locally.
- Add airbase as parent to enable release in future - Add necessary details for release - Add airbase property overrides to skip various checks to allow passing build - Centralize property declarations in parent pom - Improve dependency declarations and add version overrides as minimally needed - Improve groupid naming
Fixes #3
Fixes #14