Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed analyze request #469

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

athultr1997
Copy link
Contributor

@athultr1997 athultr1997 commented Sep 11, 2024

Description

Fixes #468

Additional context and related issues

Objectmapper expects the boolean fields without the is prefix. Hence, instead of isAnalyzeRequest, analyzeRequest should be used for configuration.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Sep 11, 2024
@athultr1997 athultr1997 self-assigned this Sep 11, 2024
@ebyhr ebyhr merged commit 785844b into trinodb:main Sep 15, 2024
1 check passed
@github-actions github-actions bot added this to the 12 milestone Sep 15, 2024
@ebyhr
Copy link
Member

ebyhr commented Sep 15, 2024

@athultr1997 Thanks for fixing this. Please avoid past tense in the commit message from next time. https://cbea.ms/git-commit/ is our commit message guideline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

analyzeRequest not explained correctly in documentation
2 participants