-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dynamic header size config for http server and client #67
add dynamic header size config for http server and client #67
Conversation
c73d913
to
0d4058f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks about ready, a couple minor comments
proxyserver/src/main/java/io/trino/gateway/proxyserver/ProxyServerConfiguration.java
Outdated
Show resolved
Hide resolved
proxyserver/src/test/java/io/trino/gateway/proxyserver/TestProxyServer.java
Outdated
Show resolved
Hide resolved
proxyserver/src/test/java/io/trino/gateway/proxyserver/TestProxyServer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more small change.
0d4058f
to
8eba231
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash commits. Approved % investigation into why the test can't use a header > 8kb even though the real server can.
4bf0292
to
db23c44
Compare
Squashed and rebased :) |
db23c44
to
06a9527
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I changed the commit message and merged.
Add dynamic header size config for http server and client
Values set in the conf are the default sizes set by Jetty
HttpConfiguration & HttpClient