Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic header size config for http server and client #67

Merged

Conversation

Chaho12
Copy link
Member

@Chaho12 Chaho12 commented Oct 5, 2023

Add dynamic header size config for http server and client

Values set in the conf are the default sizes set by Jetty
HttpConfiguration & HttpClient

  // Set size for HttpConfiguration
  private int outputBufferSize = 32 * 1024;
  private int requestHeaderSize = 8 * 1024;
  private int responseHeaderSize = 8 * 1024;

  // Set size for HttpClient
  private int requestBufferSize = 4 * 1024;
  private int responseBufferSize = 16 * 1024;

@cla-bot cla-bot bot added the cla-signed label Oct 5, 2023
@Chaho12 Chaho12 force-pushed the feature/jaeho.yoo/add_dynamic_header_size branch from c73d913 to 0d4058f Compare October 5, 2023 16:49
Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about ready, a couple minor comments

Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small change.

pom.xml Outdated Show resolved Hide resolved
@Chaho12 Chaho12 force-pushed the feature/jaeho.yoo/add_dynamic_header_size branch from 0d4058f to 8eba231 Compare October 11, 2023 18:11
Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits. Approved % investigation into why the test can't use a header > 8kb even though the real server can.

@Chaho12
Copy link
Member Author

Chaho12 commented Oct 18, 2023

Squashed and rebased :)

@Chaho12 Chaho12 force-pushed the feature/jaeho.yoo/add_dynamic_header_size branch from db23c44 to 06a9527 Compare October 24, 2023 11:10
@mosabua mosabua merged commit 9d1260a into trinodb:main Oct 24, 2023
2 checks passed
@mosabua mosabua self-requested a review October 24, 2023 17:51
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I changed the commit message and merged.

@Chaho12 Chaho12 deleted the feature/jaeho.yoo/add_dynamic_header_size branch October 25, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants