Check if url has https protocol scheme and add test #71
Conversation
andythsu
force-pushed
the
improve_jdbc_healthcheck
branch
from
de1db88
to
be39e2a
Compare
| @@ -62,7 +62,7 @@ public ClusterStats monitor(ProxyBackendConfiguration backend) { | |||
| jdbcUrl = String | |||
There was a problem hiding this comment.
Since we are getting smarter about setting the port based on the protocol, we should also use the backend URL to set the SSL parameter. Currently it is set in BackendStateConfiguration, so if you have a mixture of http and https backends it will necessarily be invalid for some of them.
There was a problem hiding this comment.
I'm not familiar with SSL parameters. So I'm assuming SSL can be set depending on http or https?
There was a problem hiding this comment.
yep
https => SSL=true
http => SSL=false
There was a problem hiding this comment.
Lets add that and then I think we should be good to merge this soon.
| private Connection con; | ||
| @Mock | ||
| private PreparedStatement stmt; | ||
| @Mock | ||
| private ResultSet rs; |
There was a problem hiding this comment.
nit - use full names like connection, preparedStatement and resultSet.
andythsu
force-pushed
the
improve_jdbc_healthcheck
branch
from
be39e2a
to
257e99e
Compare
andythsu
force-pushed
the
improve_jdbc_healthcheck
branch
from
257e99e
to
8d95ab1
Compare
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-api</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
removing this as this is a dup of line 42
andythsu
force-pushed
the
improve_jdbc_healthcheck
branch
from
8d95ab1
to
444ea3f
Compare
No description provided.