Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix basic config load issue, register log filtering #92

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix basic config load issue, register log filtering #92

merged 2 commits into from
Nov 21, 2023

Conversation

vishalya
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 14, 2023
andythsu
andythsu approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@andythsu andythsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishalya vishalya mentioned this pull request Nov 20, 2023
Closed
mosabua
mosabua approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will squash and merge

@mosabua mosabua merged commit 7d92874 into trinodb:main Nov 21, 2023
2 checks passed
@mosabua mosabua mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdsarvar rdsarvar rdsarvar left review comments

@mosabua mosabua mosabua approved these changes

@andythsu andythsu andythsu approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishalya @mosabua @rdsarvar @andythsu