Escape values of extra credentials and session properties #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
added
bug
Correctly escape values of extra credentials and session properties when building HTTP headers. Change the format of extra credentials and session properties in the URL to match the Trino JDBC and Python drivers - keys and values are separated with a colon (`:`) and multiple entries are separated with a semi-colon (`;`). Note: all special characters, including the semicolon, must be URL escaped.
nineinchnick
force-pushed
the
escape-extra-creds
branch
from
b42c56a
to
10ffefa
Compare
hashhar
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly escape values of extra credentials and session properties when
building HTTP headers.
Change the format of extra credentials and session properties in the URL
to match the Trino JDBC and Python drivers - keys and values are
separated with a colon (
:) and multiple entries are separated with asemicolon (
;). Note: all special characters, including the semicolon,must be URL escaped.
Fixes #125