Change to Apache 2.0 license #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
commented
Jul 29, 2024
| @@ -23,7 +23,7 @@ | |||
| "main": "dist/index.js", | |||
| "types": "dist/index.d.ts", | |||
| "packageManager": "yarn@3.2.1", | |||
| "license": "MIT", | |||
| "license": "Apache-2.0", | |||
There was a problem hiding this comment.
From what I can tell thats the official shorthand for package.json .. please confirm
There was a problem hiding this comment.
Should be correct according to https://spdx.org/licenses/ and https://docs.npmjs.com/cli/v10/configuring-npm/package-json?v=true#license
mosabua
commented
Jul 29, 2024
regadas
approved these changes
Jul 30, 2024
|
I will wait for @martint with merge .. and ideally also get approval from @elferherrera and @Amatrasan .. could you maybe contact them @regadas ? |
|
@mosabua yeah I can try |
elferherrera
approved these changes
Aug 14, 2024
|
Thank you for approving @elferherrera Ideally you could also chime in @Amatrasan ... |
|
I think we are good to go here .. can you give a final approval @martint ? |
martint
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would approval on this from @regadas @elferherrera and @Amatrasan