Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): path to primary entrypoint #727

Closed

Conversation

kylejb
Copy link
Member

@kylejb kylejb commented Nov 19, 2024

Fixes #721


Summary

This PR fixes the paths for "main" and "types" in package.json. index.js and index.d.ts are now nested in dist/src on build.

Copy link

cla-bot bot commented Nov 19, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@kylejb
Copy link
Member Author

kylejb commented Nov 19, 2024

I just emailed my signed CLA.

@kylejb
Copy link
Member Author

kylejb commented Nov 19, 2024

@cla-bot check

EDIT: it was worth a shot :)

Copy link

cla-bot bot commented Nov 19, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Nov 19, 2024

The cla-bot has been summoned, and re-checked this pull request!

@kylejb kylejb force-pushed the fix/721-packagejson-entrypoint branch from 45b2dd2 to 2245e1f Compare November 19, 2024 02:11
Copy link

cla-bot bot commented Nov 19, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kylejb Thank you for spotting this! I made #728 with an alternative solution as more unneeded files were being included in the release package

@mosabua
Copy link
Member

mosabua commented Nov 19, 2024

Thanks @kylejb .. we will merge the alternate PR and cut a release.

@mosabua
Copy link
Member

mosabua commented Nov 19, 2024

It would still be good for you to sign and submit a CLA for any future contributions.

@mosabua mosabua closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Error importing trino-client because of type mismatch
3 participants