Skip archiving in Glue an old table version during a table update ope…

…ration Skip archiving old table version when committing a table in Iceberg in order to avoid potentially reaching Glue table version quotas.
trinodb · Nov 15, 2023 · 6fd49b8 · 6fd49b8
1 parent 375d38d
commit 6fd49b8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/docs/src/main/sphinx/connector/metastores.md b/docs/src/main/sphinx/connector/metastores.md
@@ -295,7 +295,7 @@ described with the following additional property:
   - Skip archiving an old table version when creating a new version in a commit.
     See [AWS Glue Skip
     Archive](https://iceberg.apache.org/docs/latest/aws/#skip-archive).
-  - `false`
+  - `true`
 :::
 
 ## Iceberg-specific metastores

diff --git a/...-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/IcebergGlueCatalogConfig.java b/...-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/IcebergGlueCatalogConfig.java
@@ -19,7 +19,7 @@
 public class IcebergGlueCatalogConfig
 {
     private boolean cacheTableMetadata = true;
-    private boolean skipArchive;
+    private boolean skipArchive = true;
 
     public boolean isCacheTableMetadata()
     {

diff --git a/...berg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConfig.java b/...berg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConfig.java
@@ -29,20 +29,20 @@ public void testDefaults()
     {
         assertRecordedDefaults(recordDefaults(IcebergGlueCatalogConfig.class)
                 .setCacheTableMetadata(true)
-                .setSkipArchive(false));
+                .setSkipArchive(true));
     }
 
     @Test
     public void testExplicitPropertyMapping()
     {
         Map<String, String> properties = ImmutableMap.<String, String>builder()
                 .put("iceberg.glue.cache-table-metadata", "false")
-                .put("iceberg.glue.skip-archive", "true")
+                .put("iceberg.glue.skip-archive", "false")
                 .buildOrThrow();
 
         IcebergGlueCatalogConfig expected = new IcebergGlueCatalogConfig()
                 .setCacheTableMetadata(false)
-                .setSkipArchive(true);
+                .setSkipArchive(false);
 
         assertFullMapping(properties, expected);
     }

diff --git a/...src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogSkipArchive.java b/...src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogSkipArchive.java
@@ -82,7 +82,6 @@ protected QueryRunner createQueryRunner()
                 .setIcebergProperties(
                         ImmutableMap.<String, String>builder()
                                 .put("iceberg.catalog.type", "glue")
-                                .put("iceberg.glue.skip-archive", "true")
                                 .put("hive.metastore.glue.default-warehouse-dir", schemaDirectory.getAbsolutePath())
                                 .buildOrThrow())
                 .setSchemaInitializer(