Skip to content

Commit

Permalink
Replace assert false with fail
Browse files Browse the repository at this point in the history
  • Loading branch information
dain committed Mar 13, 2019
1 parent b47e1c0 commit 774d7ba
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
import static org.apache.hadoop.hive.ql.io.orc.CompressionKind.SNAPPY;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;

public class TestOrcReaderPositions
{
Expand Down Expand Up @@ -233,7 +234,7 @@ public void testBatchSizesForVariableWidth()
currentStringBytes += baseStringBytes;
}
else if (rowCountsInCurrentRowGroup > rowsInRowGroup) {
assertTrue(false, "read more rows in the current row group");
fail("read more rows in the current row group");
}
}
}
Expand Down Expand Up @@ -276,7 +277,7 @@ public void testBatchSizesForFixedWidth()
rowCountsInCurrentRowGroup = 0;
}
else if (rowCountsInCurrentRowGroup > rowsInRowGroup) {
assertTrue(false, "read more rows in the current row group");
fail("read more rows in the current row group");
}
}
}
Expand Down Expand Up @@ -346,7 +347,7 @@ public void testBatchSizeGrowth()
rowCountsInCurrentRowGroup = 0;
}
else if (rowCountsInCurrentRowGroup > 20) {
assertTrue(false, "read more rows in the current row group");
fail("read more rows in the current row group");
}

expectedBatchSize = min(min(nextBatchSize, MAX_BATCH_SIZE), 20 - rowCountsInCurrentRowGroup);
Expand Down

0 comments on commit 774d7ba

Please sign in to comment.