Remove unused parameter

`ensureOrdering` was always false, so effectively unused.
trinodb · Jan 31, 2024 · 7d7eb03 · 7d7eb03
1 parent b819421
commit 7d7eb03
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/core/trino-main/src/test/java/io/trino/sql/query/QueryAssertions.java b/core/trino-main/src/test/java/io/trino/sql/query/QueryAssertions.java
@@ -171,13 +171,13 @@ public void assertQueryAndPlan(
             @Language("SQL") String expected,
             PlanMatchPattern pattern)
     {
-        assertQuery(runner.getDefaultSession(), actual, expected, false);
+        assertQuery(runner.getDefaultSession(), actual, expected);
 
         Plan plan = runner.executeWithPlan(runner.getDefaultSession(), actual, WarningCollector.NOOP).getQueryPlan();
         assertPlan(runner.getDefaultSession(), runner.getPlannerContext().getMetadata(), runner.getPlannerContext().getFunctionManager(), runner.getStatsCalculator(), plan, pattern);
     }
 
-    private void assertQuery(Session session, @Language("SQL") String actual, @Language("SQL") String expected, boolean ensureOrdering)
+    private void assertQuery(Session session, @Language("SQL") String actual, @Language("SQL") String expected)
     {
         MaterializedResult actualResults = null;
         try {
@@ -200,14 +200,7 @@ private void assertQuery(Session session, @Language("SQL") String actual, @Langu
         List<MaterializedRow> actualRows = actualResults.getMaterializedRows();
         List<MaterializedRow> expectedRows = expectedResults.getMaterializedRows();
 
-        if (ensureOrdering) {
-            if (!actualRows.equals(expectedRows)) {
-                assertEquals(expectedRows, actualRows, "For query: \n " + actual + "\n:");
-            }
-        }
-        else {
-            assertEqualsIgnoreOrder(actualRows, expectedRows, "For query: \n " + actual);
-        }
+        assertEqualsIgnoreOrder(actualRows, expectedRows, "For query: \n " + actual);
     }
 
     public void assertQueryReturnsEmptyResult(@Language("SQL") String actual)