Remove unused fields on AbstractTestHiveClient

trinodb · Mar 12, 2019 · 8e1ead5 · 8e1ead5
1 parent 477974d
commit 8e1ead5
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHiveClient.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHiveClient.java
@@ -540,7 +540,6 @@ private static RowType toRowType(List<ColumnMetadata> columns)
                             .put("t_long_decimal", createDecimalColumnStatistics(Optional.empty(), Optional.empty(), OptionalLong.of(2), OptionalLong.of(1)))
                             .build());
 
-    protected String clientId;
     protected String database;
     protected SchemaTableName tablePartitionFormat;
     protected SchemaTableName tableUnpartitioned;
@@ -556,7 +555,6 @@ private static RowType toRowType(List<ColumnMetadata> columns)
     protected SchemaTableName tablePartitionSchemaChangeNonCanonical;
     protected SchemaTableName tableBucketEvolution;
 
-    protected String invalidClientId;
     protected ConnectorTableHandle invalidTableHandle;
 
     protected ColumnHandle dsColumn;
@@ -599,9 +597,8 @@ public void tearDown()
         }
     }
 
-    protected void setupHive(String connectorId, String databaseName, String timeZoneId)
+    protected void setupHive(String databaseName, String timeZoneId)
     {
-        clientId = connectorId;
         database = databaseName;
         tablePartitionFormat = new SchemaTableName(database, "presto_test_partition_format");
         tableUnpartitioned = new SchemaTableName(database, "presto_test_unpartitioned");
@@ -617,7 +614,6 @@ protected void setupHive(String connectorId, String databaseName, String timeZon
         tablePartitionSchemaChangeNonCanonical = new SchemaTableName(database, "presto_test_partition_schema_change_non_canonical");
         tableBucketEvolution = new SchemaTableName(database, "presto_test_bucket_evolution");
 
-        invalidClientId = "hive";
         invalidTableHandle = new HiveTableHandle(database, INVALID_TABLE);
         invalidTableLayoutHandle = new HiveTableLayoutHandle(
                 invalidTable,
@@ -721,9 +717,7 @@ protected final void setup(String host, int port, String databaseName, String ti
 
     protected final void setup(String databaseName, HiveClientConfig hiveClientConfig, ExtendedHiveMetastore hiveMetastore)
     {
-        HiveConnectorId connectorId = new HiveConnectorId("hive-test");
-
-        setupHive(connectorId.toString(), databaseName, hiveClientConfig.getTimeZone());
+        setupHive(databaseName, hiveClientConfig.getTimeZone());
 
         metastoreClient = hiveMetastore;
         HdfsConfiguration hdfsConfiguration = new HiveHdfsConfiguration(new HdfsConfigurationInitializer(hiveClientConfig), ImmutableSet.of());
@@ -1191,7 +1185,6 @@ public void testGetPartitionNamesException()
         }
     }
 
-    @SuppressWarnings({"ValueOfIncrementOrDecrementUsed", "UnusedAssignment"})
     @Test
     public void testGetTableSchemaPartitionFormat()
     {