Remove redundant Iceberg product tests

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseSharedMetastoreTest.java

@@ -50,8 +50,17 @@ public void testSelect()
 
         assertThat(query("SELECT * FROM iceberg." + tpchSchema + ".region"))
                 .failure().hasMessageContaining("Not an Iceberg table");
+        assertThat(query("SELECT * FROM iceberg." + tpchSchema + ".\"region$data\""))
+                .failure().hasMessageMatching(".* Table .* does not exist");
+        assertThat(query("SELECT * FROM iceberg." + tpchSchema + ".\"region$files\""))
+                .failure().hasMessageMatching(".* Table .* does not exist");
+
         assertThat(query("SELECT * FROM hive." + tpchSchema + ".nation"))
                 .failure().hasMessageContaining("Cannot query Iceberg table");
+        assertThat(query("SELECT * FROM hive." + tpchSchema + ".\"nation$partitions\""))
+                .failure().hasMessageMatching(".* Table .* does not exist");
+        assertThat(query("SELECT * FROM hive." + tpchSchema + ".\"nation$properties\""))
+                .failure().hasMessageMatching(".* Table .* does not exist");
     }
 
     @Test
@@ -87,6 +96,20 @@ public void testReadInformationSchema()
                         "('nation', 'nationkey'), ('nation', 'name'), ('nation', 'regionkey'), ('nation', 'comment')");
     }
 
+    @Test
+    void testHiveSelectTableColumns()
+    {
+        assertThat(query("SELECT table_cat, table_schem, table_name, column_name FROM system.jdbc.columns WHERE table_cat = 'hive' AND table_schem = '" + tpchSchema + "' AND table_name = 'region'"))
+                .skippingTypesCheck()
+                .matches("VALUES " +
+                        "('hive', '" + tpchSchema + "', 'region', 'regionkey')," +
+                        "('hive', '" + tpchSchema + "', 'region', 'name')," +
+                        "('hive', '" + tpchSchema + "', 'region', 'comment')");
+
+        // Hive does not show any information about tables with unsupported format
+        assertQueryReturnsEmptyResult("SELECT table_cat, table_schem, table_name, column_name FROM system.jdbc.columns WHERE table_cat = 'hive' AND table_schem = '" + tpchSchema + "' AND table_name = 'nation'");
+    }
+
     @Test
     public void testShowTables()
     {
@@ -169,6 +192,34 @@ public void testTimeTravelWithRedirection()
         }
     }
 
+    @Test
+    void testIcebergCannotCreateTableNamesakeToHiveTable()
+    {
+        String tableName = "test_iceberg_create_namesake_hive_table_" + randomNameSuffix();
+        String hiveTableName = "hive.%s.%s".formatted(testSchema, tableName);
+        String icebergTableName = "iceberg.%s.%s".formatted(testSchema, tableName);
+
+        assertUpdate("CREATE TABLE " + hiveTableName + "(a bigint)");
+        assertThat(query("CREATE TABLE " + icebergTableName + "(a bigint)"))
+                .failure().hasMessageMatching(".* Table .* of unsupported type already exists");
+
+        assertUpdate("DROP TABLE " + hiveTableName);
+    }
+
+    @Test
+    void testHiveCannotCreateTableNamesakeToIcebergTable()
+    {
+        String tableName = "test_iceberg_create_namesake_hive_table_" + randomNameSuffix();
+        String hiveTableName = "hive.%s.%s".formatted(testSchema, tableName);
+        String icebergTableName = "iceberg.%s.%s".formatted(testSchema, tableName);
+
+        assertUpdate("CREATE TABLE " + icebergTableName + "(a bigint)");
+        assertThat(query("CREATE TABLE " + hiveTableName + "(a bigint)"))
+                .failure().hasMessageMatching(".* Table .* of unsupported type already exists");
+
+        assertUpdate("DROP TABLE " + icebergTableName);
+    }
+
     @Test
     public void testMigrateTable()
     {

testing/trino-product-tests/src/main/java/io/trino/tests/product/hudi/TestHudiHiveTablesCompatibility.java

@@ -14,7 +14,6 @@
 package io.trino.tests.product.hudi;
 
 import io.trino.tempto.ProductTest;
-import io.trino.tests.product.iceberg.TestIcebergHiveTablesCompatibility;
 import org.testng.annotations.Test;
 
 import static io.trino.tempto.assertions.QueryAssert.Row.row;
@@ -30,7 +29,6 @@
  * Tests interactions between Hudi and Hive connectors, when one tries to read a table created by the other.
  *
  * @see TestHudiHiveViewsCompatibility
- * @see TestIcebergHiveTablesCompatibility
  */
 public class TestHudiHiveTablesCompatibility
         extends ProductTest
@@ -92,7 +90,7 @@ public void testHiveCannotCreateTableNamesakeToHudiTable()
         String tableName = "test_hive_create_namesake_hudi_table_" + randomNameSuffix();
         assertQueryFailure(() -> onTrino().executeQuery("CREATE TABLE hudi.default." + tableName + "(a bigint)"))
                 .hasMessageMatching("Query failed \\(#\\w+\\):\\Q This connector does not support creating tables");
-        // TODO implement test like TestIcebergHiveTablesCompatibility.testHiveCannotCreateTableNamesakeToIcebergTable when CREATE TABLE supported
+        // TODO implement test like BaseSharedMetastoreTest.testHiveCannotCreateTableNamesakeToIcebergTable when CREATE TABLE supported
     }
 
     @Test(groups = {HUDI, PROFILE_SPECIFIC_TESTS})

testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergHiveViewsCompatibility.java

@@ -34,7 +34,6 @@
 /**
  * Tests interactions between Iceberg and Hive connectors, when one tries to read a view created by the other.
  *
- * @see TestIcebergHiveTablesCompatibility
  * @see TestHudiHiveViewsCompatibility
  */
 public class TestIcebergHiveViewsCompatibility

testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergInsert.java

@@ -41,7 +41,6 @@ public class TestIcebergInsert
         extends ProductTest
 {
     /**
-     * @see TestIcebergCreateTable#testCreateTable() See TestIcebergCreateTable for a non-concurrent INSERT test coverage.
      * @see TestIcebergSparkCompatibility#testTrinoSparkConcurrentInsert()
      */
     @Test(groups = {ICEBERG, STORAGE_FORMATS_DETAILED, HMS_ONLY}, timeOut = 60_000)

testing/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergRedirectionToHive.java

@@ -37,8 +37,6 @@
 /**
  * Tests interactions between Iceberg and Hive connectors, when one tries to read a table created by the other
  * with redirects enabled.
- *
- * @see TestIcebergHiveTablesCompatibility
  */
 public class TestIcebergRedirectionToHive
         extends ProductTest